Skip to content

Commit

Permalink
fix: needs and frontend url
Browse files Browse the repository at this point in the history
  • Loading branch information
mishraomp committed Dec 29, 2024
1 parent bc7859a commit 2365b8d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/.e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: .E2E
on:
workflow_call:
inputs:
FRONTEND_URL:
frontend_url:
description: 'The URL of the frontend to test'
required: true
type: string
Expand All @@ -19,15 +19,15 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- name: Run Docker compose
if: ${{ inputs.FRONTEND_URL == 'http://localhost:3000' }}
if: ${{ inputs.frontend_url == 'http://localhost:3000' }}
env:
BACKEND_IMAGE: ghcr.io/${{ github.repository }}/backend:${{ inputs.tag }}
FLYWAY_IMAGE: ghcr.io/${{ github.repository }}/migrations:${{ inputs.tag }}
FRONTEND_IMAGE: ghcr.io/${{ github.repository }}/frontend:${{ inputs.tag }}
run: docker compose up -d --wait
continue-on-error: true
- name: Docker Compose Logs
if: ${{ runner.debug == '1' && inputs.FRONTEND_URL == 'http://localhost:3000' }}
if: ${{ runner.debug == '1' && inputs.frontend_url == 'http://localhost:3000' }}
run: docker compose logs
- name: Cache Playwright Browsers
uses: actions/cache@v4
Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
- name: Run Tests
working-directory: frontend
env:
E2E_BASE_URL: http://localhost:3000
E2E_BASE_URL: ${{ inputs.frontend_url }}
CI: 'true'
run: |
npx playwright test --project="chromium" --reporter=blob
2 changes: 1 addition & 1 deletion .github/workflows/merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
frontend_url: https://${{ needs.deploy_stack_dev.outputs.CF_DOMAIN }}
deploy_stack_test:
name: Deploy Stack Test
needs: [vars]
needs: [vars, e2e]
uses: ./.github/workflows/.deploy_stack.yml
with:
environment_name: test
Expand Down

0 comments on commit 2365b8d

Please sign in to comment.