OPS#3923 - Fix NSF status for online banking (#2820)

* Fix nsf status * put back missing lines
bcgov · May 14, 2024 · 2b8fbd3 · 2b8fbd3
1 parent 5d6e104
commit 2b8fbd3
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/auth-web/package-lock.json b/auth-web/package-lock.json
diff --git a/auth-web/package.json b/auth-web/package.json
@@ -1,6 +1,6 @@
 {
   "name": "auth-web",
-  "version": "2.6.10",
+  "version": "2.6.11",
   "appName": "Auth Web",
   "sbcName": "SBC Common Components",
   "private": true,

diff --git a/auth-web/src/components/auth/account-settings/transaction/TransactionsDataTable.vue b/auth-web/src/components/auth/account-settings/transaction/TransactionsDataTable.vue
@@ -115,7 +115,7 @@
             >
               mdi-alert
             </v-icon>
-            <b>{{ invoiceStatusDisplay[item.statusCode] }}</b>
+            <b>{{ getInvoiceStatus(item) }}</b>
             <br>
             <span
               v-if="item.updatedOn"
@@ -143,12 +143,12 @@
 
 <script lang="ts">
 import { BaseVDataTable, DatePicker, IconTooltip } from '@/components'
+import { InvoiceStatus, PaymentTypes } from '@/util/constants'
 import { Ref, computed, defineComponent, nextTick, ref, watch } from '@vue/composition-api'
 import { BaseTableHeaderI } from '@/components/datatable/interfaces'
 import CommonUtils from '@/util/common-util'
 import { DEFAULT_DATA_OPTIONS } from '@/components/datatable/resources'
 import { DataOptions } from 'vuetify'
-import { InvoiceStatus } from '@/util/constants'
 import { Transaction } from '@/models'
 import _ from 'lodash'
 import { invoiceStatusDisplay } from '@/resources/display-mappers'
@@ -171,6 +171,15 @@ export default defineComponent({
 
     const getHeaders = computed(() => props.headers)
 
+    const getInvoiceStatus = (item: Transaction) => {
+      // Special case for Online Banking - it shouldn't show NSF, should show Pending.
+      if (item.paymentMethod === PaymentTypes.ONLINE_BANKING &&
+        item.statusCode === InvoiceStatus.SETTLEMENT_SCHEDULED) {
+        return invoiceStatusDisplay[InvoiceStatus.PENDING]
+      }
+      return invoiceStatusDisplay[item.statusCode]
+    }
+
     // date picker stuff
     const dateRangeReset = ref(0)
     const dateRangeSelected = ref(false)
@@ -264,7 +273,8 @@ export default defineComponent({
       displayDate,
       scrollToDatePicker,
       updateDateRange,
-      loadTransactionList
+      loadTransactionList,
+      getInvoiceStatus
     }
   }
 })