Skip to content

Commit

Permalink
12565 - Logout not clearing Siteminder cookies (#1996)
Browse files Browse the repository at this point in the history
* Adding in SITEMINDER_LOGOUT_URL into configuration.json.

* Minor tweaks.

* Update sbc-common-components version.
  • Loading branch information
seeker25 authored Jun 21, 2022
1 parent 124376d commit b29e792
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 10 deletions.
14 changes: 7 additions & 7 deletions auth-web/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion auth-web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"moment": "^2.24.0",
"regenerator-runtime": "^0.13.3",
"register-service-worker": "^1.6.2",
"sbc-common-components": "2.4.52",
"sbc-common-components": "2.4.53",
"vue": "2.6.12",
"vue-i18n": "^8.0.0",
"vue-plugin-helper-decorator": "0.0.12",
Expand Down
3 changes: 2 additions & 1 deletion auth-web/public/config/configuration.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,6 @@
"CORPORATE_ONLINE_URL": "https://dev.corponline.gov.bc.ca/",
"FAS_WEB_URL": "https://fas-dev.apps.silver.devops.gov.bc.ca/",
"API_DOCUMENTATION_URL": "https://developer.bcregistry.daxiom.ca/apis-summary/",
"PPR_WEB_URL": "https://ppr-ui-dev.apps.silver.devops.gov.bc.ca/ppr/"
"PPR_WEB_URL": "https://ppr-ui-dev.apps.silver.devops.gov.bc.ca/ppr/",
"SITEMINDER_LOGOUT_URL": "https://logontest7.gov.bc.ca/clp-cgi/logoff.cgi"
}
5 changes: 5 additions & 0 deletions auth-web/src/util/config-helper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export default class ConfigHelper {
sessionStorage.setItem(SessionStorageKeys.RegistryHomeUrl, ConfigHelper.getRegistryHomeURL())
sessionStorage.setItem(SessionStorageKeys.NameRequestUrl, ConfigHelper.getNameRequestUrl())
sessionStorage.setItem(SessionStorageKeys.PprWebUrl, ConfigHelper.getPPRWebUrl())
sessionStorage.setItem(SessionStorageKeys.SiteminderLogoutUrl, ConfigHelper.getSiteminderLogoutUrl())
}

/**
Expand Down Expand Up @@ -134,6 +135,10 @@ export default class ConfigHelper {
return ConfigHelper.getValue('PPR_WEB_URL')
}

static getSiteminderLogoutUrl () {
return ConfigHelper.getValue('SITEMINDER_LOGOUT_URL')
}

static apiDocumentationUrl () {
return ConfigHelper.getValue('API_DOCUMENTATION_URL')
}
Expand Down
3 changes: 2 additions & 1 deletion auth-web/src/util/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ export enum SessionStorageKeys {
AffidavitNeeded = 'AFFIDAVIT_NEEDED',
GOVN_USER='AUTH_GOVN_USER',
NameRequestUrl = 'NAME_REQUEST_URL',
PprWebUrl = 'PPR_WEB_URL'
PprWebUrl = 'PPR_WEB_URL',
SiteminderLogoutUrl = 'SITEMINDER_LOGOUT_URL'
}

export enum Role {
Expand Down

0 comments on commit b29e792

Please sign in to comment.