Skip to content

Commit

Permalink
13205 - Minor fixes based on Ashna's feedback. (#2166)
Browse files Browse the repository at this point in the history
* Minor fixes based on Ashna's feedback.

* Unit test fix.
  • Loading branch information
seeker25 authored Nov 28, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 8d4f562 commit ef84350
Showing 3 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion auth-web/src/components/auth/common/LinkedBCOLBanner.vue
Original file line number Diff line number Diff line change
@@ -49,7 +49,7 @@
</div>
</div>
</v-alert>
<BcolLogin v-if="editMode" :hideLinkBtn="true" :defaultUserId="bcolAccountDetails.userId" @emit-bcol-info="emitBcolInfo" ></BcolLogin>
<BcolLogin v-if="editMode" :hideLinkBtn="true" @emit-bcol-info="emitBcolInfo" ></BcolLogin>
</div>
</template>

2 changes: 0 additions & 2 deletions auth-web/src/components/auth/create-account/BcolLogin.vue
Original file line number Diff line number Diff line change
@@ -78,12 +78,10 @@ export default class BcolLogin extends Vue {
private errorMessage: string = ''
private isLoading: boolean = false
@Prop({ default: false }) hideLinkBtn: boolean
@Prop() defaultUserId: string
@OrgModule.Action('validateBcolAccount')
private readonly validateBcolAccount!: (bcolProfile: BcolProfile) => Promise<BcolAccountDetails>
private async mounted () {
this.username = this.defaultUserId || this.username
this.password = ''
}
Original file line number Diff line number Diff line change
@@ -59,11 +59,8 @@ describe('StaffRejectedAccountsTable.vue', () => {
jest.clearAllMocks()
})

it('is a Vue instance', () => {
it('is a Vue instance and has a data table', () => {
expect(wrapper.isVueInstance()).toBeTruthy()
})

it('Should have data table', () => {
expect(wrapper.find('.user-list')).toBeTruthy()
})
})

0 comments on commit ef84350

Please sign in to comment.