-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
19908 & 19907 - PUB/SUB Queue upgrades for Python 3.8 master branch #2779
Conversation
…re. Unit test fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job on all the clean up so far! thanks!
Will give it another pass when it is ready.
Note: Will refactor enums into sbc-common-components. Still waiting on Jia to provide the enums for pay. |
Haven't done much local testing, just rebuilt new queues - unit tests based off of requests. |
I've setup the topics in GCP for DEV and updated the diagrams. Determined most of the secrets. Next: testing auth-api/auth-queue/account-mailer locally - using ngrok to forward to my flask instances |
Seems to be working locally using ngrok. |
Works locally with Namex-pay. Some small tweaks were required. I've let Andriy know. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2779 +/- ##
==========================================
+ Coverage 80.71% 89.31% +8.60%
==========================================
Files 322 167 -155
Lines 11915 9043 -2872
Branches 618 0 -618
==========================================
- Hits 9617 8077 -1540
+ Misses 2289 966 -1323
+ Partials 9 0 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…pgrades # Conflicts: # .github/workflows/auth-queue-ci.yml # .github/workflows/events-listener-ci.yml
Quality Gate passedIssues Measures |
bcgov/entity#19908
bcgov/entity#19907
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).