Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19908 & 19907 - PUB/SUB Queue upgrades for Python 3.8 master branch #2779

Merged
merged 41 commits into from
May 14, 2024

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Apr 30, 2024

bcgov/entity#19908
bcgov/entity#19907

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

Copy link
Collaborator

@ochiu ochiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job on all the clean up so far! thanks!

Will give it another pass when it is ready.

@seeker25 seeker25 changed the title Queue upgrades 19908 & 19907 - PUB/SUB Queue upgrades May 1, 2024
@seeker25
Copy link
Collaborator Author

seeker25 commented May 2, 2024

Note: Will refactor enums into sbc-common-components. Still waiting on Jia to provide the enums for pay.

@seeker25 seeker25 marked this pull request as ready for review May 2, 2024 16:52
@seeker25 seeker25 requested a review from bolyachevets May 2, 2024 17:03
@seeker25
Copy link
Collaborator Author

seeker25 commented May 2, 2024

Haven't done much local testing, just rebuilt new queues - unit tests based off of requests.
Still need to configure GCP PUB/SUB and make sure all secrets are in line etc.
Next steps are to complete that and work with Jia for some integration testing on DEV.

@seeker25
Copy link
Collaborator Author

seeker25 commented May 2, 2024

I've setup the topics in GCP for DEV and updated the diagrams.

Determined most of the secrets.

Next: testing auth-api/auth-queue/account-mailer locally - using ngrok to forward to my flask instances

@seeker25
Copy link
Collaborator Author

seeker25 commented May 2, 2024

Seems to be working locally using ngrok.

@seeker25
Copy link
Collaborator Author

seeker25 commented May 6, 2024

Works locally with Namex-pay. Some small tweaks were required. I've let Andriy know.

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 55.29412% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 89.31%. Comparing base (261dc17) to head (594d84a).
Report is 303 commits behind head on main.

❗ Current head 594d84a differs from pull request most recent head e2cf50b. Consider uploading reports for the commit e2cf50b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2779      +/-   ##
==========================================
+ Coverage   80.71%   89.31%   +8.60%     
==========================================
  Files         322      167     -155     
  Lines       11915     9043    -2872     
  Branches      618        0     -618     
==========================================
- Hits         9617     8077    -1540     
+ Misses       2289      966    -1323     
+ Partials        9        0       -9     
Flag Coverage Δ
accountmailerqueue ?
activityloglistenerqueue ?
authapi 89.31% <55.29%> (-0.65%) ⬇️
authweb ?
eventlistenerqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
auth-api/src/auth_api/__init__.py 85.71% <100.00%> (+0.38%) ⬆️
auth-api/src/auth_api/config.py 99.41% <100.00%> (+0.01%) ⬆️
auth-api/src/auth_api/schemas/contact.py 100.00% <100.00%> (ø)
...pi/src/auth_api/services/activity_log_publisher.py 88.46% <100.00%> (+0.46%) ⬆️
...pi/src/auth_api/services/affiliation_invitation.py 82.86% <100.00%> (-2.92%) ⬇️
auth-api/src/auth_api/services/entity.py 97.02% <100.00%> (+0.07%) ⬆️
...th-api/src/auth_api/services/gcp_queue/__init__.py 100.00% <100.00%> (ø)
auth-api/src/auth_api/services/user.py 93.16% <100.00%> (-0.25%) ⬇️
auth-api/src/auth_api/utils/enums.py 100.00% <ø> (ø)
auth-api/src/auth_api/utils/notifications.py 98.75% <100.00%> (ø)
... and 7 more

... and 167 files with indirect coverage changes

@seeker25 seeker25 changed the title 19908 & 19907 - PUB/SUB Queue upgrades 19908 & 19907 - PUB/SUB Queue upgrades for Python 3.8 master branch May 13, 2024
Copy link

sonarqubecloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
11 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.6% Duplication on New Code

See analysis details on SonarCloud

@seeker25 seeker25 merged commit d620cd7 into bcgov:main May 14, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants