19024 - Implemented the Involuntary Dissolution Screen #2805
Conversation
JazzarKarim
force-pushed
the
19024-invol-dissolution-screen
branch
from
4750ce2 to
1495c48
Compare
| @@ -0,0 +1,64 @@ | |||
| <template> | |||
There was a problem hiding this comment.
The Card header:
| > | ||
| <span> | ||
| Moving <strong>{{ scheduleSummaryNumber }}</strong> businesses into D1 dissolution every | ||
| <strong>Tuesday</strong> at <strong>11:59 p.m</strong> Pacific Time. |
There was a problem hiding this comment.
The Tuesday and hour here will probably change later.
|
|
||
| @Component({ | ||
| methods: { | ||
| ...mapActions(useStaffStore, |
There was a problem hiding this comment.
We usually use the @Getter and @Action in our entities codebases but in here, I'm just following the coding practice of relationships to stay uniform across all files 😃
There was a problem hiding this comment.
I was going to comment on this, not because I think mapActions() is bad, but because you also need to declare the method signatures on lines 158-161. DRY if possible.
| menu = false | ||
| numberOfBusinesses = 0 | ||
| isEdit = false | ||
| isOnHold = false |
There was a problem hiding this comment.
You may notice that I'm using the onHold a lot (instead of isRunning for example). This is because, from the configurations table (got this from Argus), we'll be getting something like this:
{
"configurations": [
{
"name": "NUM_DISSOLUTIONS_ALLOWED",
"value": "100"
},
{
"name": "DISSOLUTIONS_ON_HOLD",
"value": false
},
...
]
}So, I'm using the on hold term.
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-2805-ip6uoedq.web.app Please try: https://bcregistry-account-dev--pr-2805-ip6uoedq.web.app/staff/involuntary-dissolution |
JazzarKarim
requested review from
Jxio,
seeker25,
ochiu and
rodrigo-barraza
as code owners
auth-web/package.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| "@bcrs-shared-components/corp-type-module": "1.0.16", | |||
| "@bcrs-shared-components/enums": "1.1.10", | |||
| "@bcrs-shared-components/interfaces": "1.1.13", | |||
| "@mdi/font": "^4.5.95", | |||
| "@mdi/font": "^5.9.55", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
@JazzarKarim I believe there were icons we are currently using that have been removed in newer versions, so I had to revert the changes as it affected other screens.
There was a problem hiding this comment.
I see, OK. Got it. Thank you so much Ody.
I will talk to our UX designer and will see if we can use something else in this case. Appreciate it!
There was a problem hiding this comment.
You can also pull in icons separately if the font doesn't have them.
There was a problem hiding this comment.
Reverted this change to not break other stuff as Ody mentioned.
|
|
Got the OK to merge from Travis. Merging now. |
Issue #:
bcgov/entity#19024
Designs: https://www.figma.com/file/LcP4NgVYKVxEk8V7fXWIuc/Involuntary-Dissolution-%26-Delay-of-Dissolution?type=design&node-id=390-3159&mode=design
Description of changes:
NOTE: Unit tests will be done in bcgov/entity#21154
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).