Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21204 - Create migration that add EFT and PAD into suspension_reason_codes #2844

Merged
merged 3 commits into from
May 29, 2024

Conversation

sameer0422
Copy link
Collaborator

Issue #:
bcgov/entity#21204

Description of changes: Create migration that updates suspension_reason_code

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@sameer0422
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2844-em9wmvys.web.app

@Jxio
Copy link
Collaborator

Jxio commented May 29, 2024

I think it need a datafix check NSF_SUSPENDED orgs payment method, if it's PAD, then add 'PAD_NSF'

@sameer0422
Copy link
Collaborator Author

@Jxio can you give me the final code & description for EFT and PAD?
EFT_NSF, PAD_NSF?

@sameer0422 sameer0422 requested a review from Jxio May 29, 2024 20:40
@sameer0422
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2844-em9wmvys.web.app

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sameer0422
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2844-em9wmvys.web.app

Copy link
Collaborator

@Jxio Jxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sameer0422 sameer0422 merged commit 9349b02 into bcgov:main May 29, 2024
6 checks passed
@sameer0422 sameer0422 deleted the 21204-eft-pad branch May 29, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants