23620 - Add in year filter #3162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-3162-tcls9493.web.app |
|
seeker25
commented
Nov 29, 2024
| transactions.filters.filterPayload = { dateFilter: { startDate: '', endDate: '' } } | ||
| transactions.filters.isActive = false | ||
| transactions.filters.pageNumber = 1 | ||
| loadTransactionList() | ||
| if (!skipLoadTransactions) { |
There was a problem hiding this comment.
Fix double load issue
|
Temporary Url for review: https://bcregistry-account-dev--pr-3162-tcls9493.web.app |
seeker25
commented
Nov 29, 2024
| @@ -4,6 +4,8 @@ | |||
| v-show="showDatePicker" | |||
| ref="datePicker" | |||
| :reset="dateRangeReset" | |||
| :setStartDate="transactions.filters.filterPayload.dateFilter.startDate" | |||
There was a problem hiding this comment.
only gets set once
seeker25
commented
Nov 29, 2024
| @@ -73,7 +75,7 @@ | |||
| filled | |||
| hide-details | |||
| :placeholder="'Date'" | |||
| :value="dateRangeSelected ? 'Custom' : ''" | |||
| :value="dateRangeSelected ? 'Custom' : '1 Year'" | |||
There was a problem hiding this comment.
Custom disappears with clear (no text), also shows up after you click a date
ochiu
approved these changes
Nov 29, 2024
seeker25
commented
Nov 29, 2024
| transactions.filters.filterPayload = { | ||
| dateFilter: { | ||
| startDate: moment().subtract(1, 'year').format('YYYY-MM-DD'), | ||
| endDate: moment().add(1, 'day').format('YYYY-MM-DD') |
There was a problem hiding this comment.
Just in case it sits for a bit and rolls over midnight somehow (EG. Leaving auth-web open for hours then using it) - I guess I could have used a massive date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#23620
Description of changes:
Add in yearly filter for transactions, should smooth out the load on pay-api for the large transaction screen as well as the smaller client ones.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).