24576 - Updates to NSF messaging #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeker25
reviewed
Jan 16, 2025
| @State(useOrgStore) private currentOrganization!: Organization | ||
| @State(useCodesStore) private suspensionReasonCodes!: Code[] | ||
| private formatDate = CommonUtils.formatDisplayDate | ||
| export default defineComponent({ |
seeker25
reviewed
Jan 16, 2025
auth-web/src/components/auth/account-freeze/AccountOverviewNSF.vue
Outdated
Show resolved
Hide resolved
seeker25
approved these changes
Jan 16, 2025
seeker25
reviewed
Jan 16, 2025
auth-web/src/util/common-util.ts
Outdated
| @@ -148,6 +148,11 @@ export default class CommonUtils { | |||
| static formatDatePickerDate (date?: Date) { | |||
| return moment(date || new Date()).format('YYYY-MM-DD') | |||
| } | |||
|
|
|||
| static formatDateToHumanReadable (date: Date | string | moment.Moment) { | |||
There was a problem hiding this comment.
type DateLike = string | Date | moment.Moment
date: DateLike
can replace line 141 too like this
seeker25
reviewed
Jan 21, 2025
| @@ -21,7 +21,7 @@ | |||
| Account Suspended | |||
| </div> | |||
| <div> | |||
| Account has been suspended for {{ accountSuspendReason }}. | |||
| This acount has been suspended. Returned system error message: {{ reason }}. | |||
seeker25
reviewed
Jan 21, 2025
| @@ -85,16 +85,9 @@ | |||
| {{ currentOrganization.name }} | |||
| </h1> | |||
| <p | |||
| v-if="isPremiumAccount" | |||
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#24576
Description of changes:
Added reason to client view NSF when account is suspended.
Added reason to admin view when viewing a suspended account.
Updated NSF copy and icons.
Cleaned up date formats to be more human-readable.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).