Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

26363 - Update Business Search product selector (tile) #3294

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hfekete
Copy link
Collaborator

@hfekete hfekete commented Mar 7, 2025

*Issue #:26363 *
bcgov/entity#26363

Description of changes:
Update Business Search product selector (tile)

  • updating title
  • updating card text

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@hfekete hfekete requested a review from kialj876 March 7, 2025 00:10
@hfekete hfekete self-assigned this Mar 7, 2025
Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things to verify

@kialj876 kialj876 requested a review from seeker25 March 7, 2025 14:22
@kialj876
Copy link
Collaborator

kialj876 commented Mar 7, 2025

fyi @seeker25 we're hoping to get these text changes in prod on March 11 - do you think that'll be okay?

@seeker25
Copy link
Collaborator

seeker25 commented Mar 7, 2025

fyi @seeker25 we're hoping to get these text changes in prod on March 11 - do you think that'll be okay?

Let me talk with the team, might be a better idea to merge this into what's already been released (EG. Hotfix)

Copy link

sonarqubecloud bot commented Mar 7, 2025

@kialj876
Copy link
Collaborator

kialj876 commented Mar 7, 2025

fyi @seeker25 we're hoping to get these text changes in prod on March 11 - do you think that'll be okay?

Let me talk with the team, might be a better idea to merge this into what's already been released (EG. Hotfix)

Okay sounds good let us know. Should we leave it to you to do the merge?

@seeker25
Copy link
Collaborator

seeker25 commented Mar 7, 2025

Yup, will have to be a hotfix. I've marked it on my calendar

@hfekete
Copy link
Collaborator Author

hfekete commented Mar 10, 2025

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-test-3294-f1dikzgz.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3294-ngfygb6e.web.app

@seeker25 seeker25 changed the base branch from main to release/2.12.0 March 10, 2025 18:01
@seeker25 seeker25 changed the base branch from release/2.12.0 to main March 10, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants