Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter create another attribute similar to + rather than submit schema #751

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

Gavinok
Copy link
Collaborator

@Gavinok Gavinok commented Aug 9, 2023

This PR resolves #747

Now when enter is hit a new attribute is added similar to how + works now

Signed-off-by: Gavin <gavinfreeborn@gmail.com>
@Gavinok Gavinok requested review from swcurran and loneil August 9, 2023 16:22
Signed-off-by: Gavin <gavinfreeborn@gmail.com>
@Gavinok Gavinok temporarily deployed to development August 9, 2023 22:33 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

@swcurran
Copy link
Contributor

swcurran commented Aug 9, 2023

I just tried it and it didn’t seem to work. When I hit “Enter” the schema is created. I want it to add another attribute.

I tried using the deployment URLs for this. Perhaps we need a zoom session for this?

Signed-off-by: Gavin <gavinfreeborn@gmail.com>
@Gavinok Gavinok temporarily deployed to development August 10, 2023 00:18 — with GitHub Actions Inactive
@Gavinok
Copy link
Collaborator Author

Gavinok commented Aug 10, 2023

@swcurran Just fixed this. Not sure why this wasn't occurring on my local deployment. Now it should work as expected 😄

Copy link
Collaborator

@loneil loneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me after latest change, chrome and firefox.

Not sure if the ideal UX would be for it to tab down to the newly created box on enter as well... but the crux of it is to not submit the form, so if that can be done with this one-liner then IMO: 👍

Actually I kind of like it not tabbing down anyways since if I know I need to add 10 fields I hit enter 10 times at the start and then tab through filling them out personally.

@Gavinok Gavinok temporarily deployed to development August 10, 2023 03:08 — with GitHub Actions Inactive
@swcurran swcurran merged commit b516b88 into main Aug 10, 2023
11 checks passed
@swcurran swcurran temporarily deployed to development August 10, 2023 16:05 — with GitHub Actions Inactive
@loneil loneil deleted the prevent-submit-on-enter branch August 11, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Hitting enter when adding schema attributes creates the schema
3 participants