-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enter create another attribute similar to + rather than submit schema #751
Conversation
Signed-off-by: Gavin <gavinfreeborn@gmail.com>
Signed-off-by: Gavin <gavinfreeborn@gmail.com>
Deployment URLs ready for review. |
I just tried it and it didn’t seem to work. When I hit “Enter” the schema is created. I want it to add another attribute. I tried using the deployment URLs for this. Perhaps we need a zoom session for this? |
Signed-off-by: Gavin <gavinfreeborn@gmail.com>
@swcurran Just fixed this. Not sure why this wasn't occurring on my local deployment. Now it should work as expected 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me after latest change, chrome and firefox.
Not sure if the ideal UX would be for it to tab down to the newly created box on enter as well... but the crux of it is to not submit the form, so if that can be done with this one-liner then IMO: 👍
Actually I kind of like it not tabbing down anyways since if I know I need to add 10 fields I hit enter 10 times at the start and then tab through filling them out personally.
This PR resolves #747
Now when enter is hit a new attribute is added similar to how
+
works now