Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFFDRS py - Use github #3928

Merged
merged 7 commits into from
Sep 16, 2024
Merged

CFFDRS py - Use github #3928

merged 7 commits into from
Sep 16, 2024

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Sep 16, 2024 •
edited by github-actions bot
Loading

conbrad
conbrad reviewed Sep 16, 2024
View reviewed changes
api/pyproject.toml Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Sep 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (b541b68) to head (f826c09).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3928   +/-   ##
=======================================
  Coverage   81.35%   81.35%           
=======================================
  Files         298      298           
  Lines       11421    11421           
  Branches      546      546           
=======================================
  Hits         9292     9292           
  Misses       2094     2094           
  Partials       35       35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettedw brettedw marked this pull request as ready for review September 16, 2024 18:08
conbrad
conbrad approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 16, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@brettedw brettedw temporarily deployed to production September 16, 2024 20:12 Inactive
@brettedw brettedw merged commit 8213ad4 into main Sep 16, 2024
25 checks passed
@brettedw brettedw deleted the task/cffdrs-py-github branch September 16, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conbrad conbrad conbrad approved these changes

@dgboss dgboss dgboss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brettedw @conbrad @dgboss