ASA Advisory Status Bar #3980
ASA Advisory Status Bar #3980
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3980 +/- ##
=======================================
Coverage 80.01% 80.01%
=======================================
Files 302 302
Lines 11466 11466
Branches 549 549
=======================================
Hits 9175 9175
Misses 2106 2106
Partials 185 185 ☔ View full report in Codecov by Sentry. |
| {title} | ||
| </Typography> | ||
| </StyledAccordionSummary> | ||
| {advisoryStatus && ( |
There was a problem hiding this comment.
I'm not a fan of the way the UI 'jumps' when switching between a fire zone unit that has an advisory/warning and one that doesn't. What do you think about removing this check for advisoryStatus and having the AdvisoryStatusBar display with the default background when there is no advisory status?
There was a problem hiding this comment.
Yep, can do something that. Will need to sort out some different styling logic in that case, otherwise every drop down will have a grey/white hash bar
There was a problem hiding this comment.
Yeah, definitely don't want a grey/white hashbar anywhere. I'm thinking just a solid bar all the time when there is no advisoryStatus.
There was a problem hiding this comment.
Addressed in 0b29a3b. Added showAdvisoryStatusBar so we don't also get an extra 10px grey bar on the stats dropdown, thoughts?
|
All good! Appreciate the feedback, I like the non-jumpiness too |
Adds coloured advisory hash bar to the advisory report dropdown. Bar only visible if there is Warning or Advisory status
Closes ASA Hashing #3963
Additional minor change: updates default tab colour to white to match figma design
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator