Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/empty cell validation morecast #3982

Merged
merged 21 commits into from
Oct 2, 2024
Merged

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Oct 1, 2024

Adds back changes from #3957

Adds bug fix in bcaef5b that allows ModelChoice.NULL for default precip values

Closes #3954

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.01%. Comparing base (2873115) to head (bcaef5b).

Files with missing lines Patch % Lines
...c/features/moreCast2/components/TabbedDataGrid.tsx 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3982      +/-   ##
==========================================
+ Coverage   79.94%   80.01%   +0.06%     
==========================================
  Files         298      302       +4     
  Lines       11431    11466      +35     
  Branches      541      549       +8     
==========================================
+ Hits         9139     9175      +36     
  Misses       2106     2106              
+ Partials      186      185       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 1, 2024

@conbrad conbrad temporarily deployed to production October 1, 2024 23:00 Inactive
@brettedw brettedw merged commit 43f30bf into main Oct 2, 2024
25 checks passed
@brettedw brettedw deleted the task/empty-cell-validation-morecast branch October 2, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Morecast: Empty input validation
3 participants