Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/bump base image deps #3983

Open
wants to merge 60 commits into
base: main
Choose a base branch
from
Open

Task/bump base image deps #3983

wants to merge 60 commits into from

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Oct 2, 2024

  • Rebuilt wps-api-base image to pick up Ubuntu 24.04 which comes with python 3.12.3 and gdal 3.8.4
  • Installing gdal for builds requires a few more flags otherwise it won't recognize the numpy installation
  • Images already have GID 1000 and UID 1000 so a new user with ID 1010 is created and added to existing GID 1000 for mount permissions
  • A bunch of fixes to C-Haines code that started failing tests with new poetry updates
  • Documentation and setup script updates to reference the new python version

Closes #3815

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 77.88945% with 44 lines in your changes missing coverage. Please review.

Project coverage is 80.02%. Comparing base (8aefeda) to head (5a65059).

Files with missing lines Patch % Lines
api/app/jobs/common_model_fetchers.py 39.28% 34 Missing ⚠️
api/app/c_haines/severity_index.py 87.69% 8 Missing ⚠️
api/app/c_haines/fetch.py 97.91% 1 Missing ⚠️
api/app/routers/c_haines.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3983   +/-   ##
=======================================
  Coverage   80.01%   80.02%           
=======================================
  Files         302      302           
  Lines       11466    11468    +2     
  Branches      549      549           
=======================================
+ Hits         9175     9177    +2     
  Misses       2106     2106           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@conbrad conbrad marked this pull request as ready for review October 2, 2024 23:21
@@ -19,7 +19,7 @@ parameters:
- name: GIT_URL
value: https://github.com/bcgov/wps.git
- name: GIT_BRANCH
value: main
value: task/bump-base-image-deps
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: not going to merge this as is, once approved I'll change it back

@@ -32,7 +32,7 @@ parameters:
- name: DOCKER_IMAGE
description: Location of docker image
required: true
value: image-registry.openshift-image-registry.svc:5000/e1e498-tools/wps-api-base:ubuntu.22.04-latest
value: image-registry.openshift-image-registry.svc:5000/e1e498-tools/wps-api-base:02-10-2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: not going to merge as is, once approved will retag wps-api-base:02-10-2024 as wps-api-base:ubuntu.24.04-latest

@conbrad conbrad closed this Oct 3, 2024
@conbrad conbrad reopened this Oct 3, 2024
@conbrad conbrad closed this Oct 3, 2024
@conbrad conbrad reopened this Oct 3, 2024
@conbrad conbrad closed this Oct 3, 2024
@conbrad conbrad reopened this Oct 3, 2024
@conbrad conbrad closed this Oct 7, 2024
@conbrad conbrad reopened this Oct 7, 2024
@conbrad conbrad closed this Oct 7, 2024
@conbrad conbrad reopened this Oct 7, 2024
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GDAL to latest version in base image
1 participant