Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24 hour precip diff issue #3989

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

24 hour precip diff issue #3989

wants to merge 2 commits into from

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Oct 7, 2024

After a review of logs I believe we are in a race with the ECCC as they upload RDPS data for the most recent model run and we try to download it. We try to download 36 hours worth of gribs when only a subset of those files may be available.

I'm moving a None check to confirm this is the case.

If this is the case, I think it is an expected behaviour and we will have to add some logic to handle the partial download of a set of precip grib files.

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.04%. Comparing base (8aefeda) to head (4ddce41).

Files with missing lines Patch % Lines
api/app/weather_models/precip_rdps_model.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3989      +/-   ##
==========================================
+ Coverage   80.01%   80.04%   +0.02%     
==========================================
  Files         302      302              
  Lines       11466    11466              
  Branches      549      549              
==========================================
+ Hits         9175     9178       +3     
+ Misses       2106     2105       -1     
+ Partials      185      183       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@conbrad conbrad closed this Oct 8, 2024
@conbrad conbrad reopened this Oct 8, 2024
Copy link

sonarcloud bot commented Oct 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants