Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proportional advisory fuel type areas #4249

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Feb 5, 2025

  • migrations to create a table to store area of each fuel type per fire zone unit
  • populate new table from the fuel raster via a Kubernetes job
  • modify FuelSummary component to display proportion of fuel type with high HFI

Closes #4193

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
PSU Insights

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 12.94118% with 74 lines in your changes missing coverage. Please review.

Project coverage is 80.20%. Comparing base (88355d3) to head (474075e).

Files with missing lines Patch % Lines
api/app/jobs/fuel_type_areas_per_zone.py 0.00% 69 Missing ⚠️
api/app/utils/geospatial.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4249      +/-   ##
==========================================
- Coverage   80.68%   80.20%   -0.48%     
==========================================
  Files         312      313       +1     
  Lines       12037    12121      +84     
  Branches      540      540              
==========================================
+ Hits         9712     9722      +10     
- Misses       2137     2211      +74     
  Partials      188      188              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgboss dgboss closed this Feb 5, 2025
@dgboss dgboss reopened this Feb 5, 2025
@dgboss dgboss closed this Feb 5, 2025
@dgboss dgboss reopened this Feb 5, 2025
@dgboss dgboss requested a review from brettedw February 6, 2025 17:08
@dgboss dgboss requested a review from conbrad February 6, 2025 17:08
@@ -311,6 +311,11 @@ objects:
configMapKeyRef:
name: ${GLOBAL_NAME}
key: env.classified_tpi_dem_fuel_masked_name
- name: FUEL_RASTER_NAME
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be missing something but is this needed in deploy?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. It's not needed in the API container; it was leftover from when I was trying to do the data migration with alembic.

Copy link

sonarqubecloud bot commented Feb 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASA: Fuel type percentages in dashboard table
3 participants