Skip to content

[ DEVSU-2468] gkb/new-user uses request user permission for user creation #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2025

Conversation

kttkjl
Copy link
Member

@kttkjl kttkjl commented Mar 19, 2025

IPR login middleware don't work here, since the graphKb path already uses the normal middleware, had to override

@kttkjl kttkjl requested review from bnguyen-bcgsc and elewis2 March 19, 2025 21:51
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 22.72727% with 17 lines in your changes missing coverage. Please review.

Project coverage is 77.07%. Comparing base (32f6eff) to head (40a7b31).

Files with missing lines Patch % Lines
app/routes/graphkb/index.js 22.72% 16 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #437      +/-   ##
===========================================
- Coverage    77.18%   77.07%   -0.11%     
===========================================
  Files          179      179              
  Lines         6135     6150      +15     
  Branches       714      714              
===========================================
+ Hits          4735     4740       +5     
- Misses        1323     1332       +9     
- Partials        77       78       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

elewis2
elewis2 previously approved these changes Mar 19, 2025
bnguyen-bcgsc
bnguyen-bcgsc previously approved these changes Mar 20, 2025
@kttkjl kttkjl dismissed stale reviews from elewis2 and bnguyen-bcgsc via 40a7b31 March 26, 2025 17:20
@kttkjl kttkjl requested review from bnguyen-bcgsc and elewis2 March 26, 2025 21:32
@kttkjl
Copy link
Member Author

kttkjl commented Mar 26, 2025

Added error handling for graphKBAPI calls, status gets lost when coming in from graphKBAPI and back into client

@kttkjl kttkjl merged commit 7206e05 into develop Apr 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants