fix(components/layout): update description list harness to use empty array pattern#11
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
Conversation
…mpty array pattern Update the test for getContent() to expect an empty array instead of throwing an error when no description list content items are found. This aligns with the simplified harness API where methods returning arrays now return empty arrays instead of throwing errors. Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…ty array instead of throwing error Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
devin-ai-integration
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the description list harness to align with the simplified harness API breaking change in SKY UX 10.0.0. The
getContent()method now returns an empty array instead of throwing an error when no description list content items are found.Changes
Harness implementation (
description-list-harness.ts):getContent()now returns the result directly (empty array if no items)Test file (
description-list-harness.spec.ts):[]instead of expecting a rejected promise with error messageThis change follows the migration pattern documented in
docs/addressing-breaking-changes/simplified-child-harness-methods/README.md.Review & Testing Checklist for Human
SkyActionButtonContainerHarness.getActionButtons())'Unable to find any description list content.'errorNotes