fix: remove technical debt comments and implement breaking changes#12
Open
devin-ai-integration[bot] wants to merge 4 commits intomainfrom
Open
fix: remove technical debt comments and implement breaking changes#12devin-ai-integration[bot] wants to merge 4 commits intomainfrom
devin-ai-integration[bot] wants to merge 4 commits intomainfrom
Conversation
- Update date service format aliases to use explicit formats instead of shorthand notation - Change EventEmitter<any> to EventEmitter<void> in sort-item component - Make flyout instance constructor parameter required (remove optional) - Remove outdated TODO comment from repeater service - Update date service tests to match new format aliases Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
- Update date.pipe.spec.ts French locale tests to expect '12:00 h' format - Update date.service.spec.ts to expect 2-digit years from 'M/d/yy' format - Update date.service.spec.ts French locale tests to expect new format Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses technical debt by implementing breaking changes that were previously marked with TODO comments. The changes include:
Date Service Format Aliases: Updated format aliases from shorthand notation (e.g.,
yMdjm) to explicit formats (e.g.,M/d/yy, h:mm a) as indicated by TODO comments. This affectsshort,medium,shortDate,mediumDate,longDate,fullDate,shortTime, andmediumTimeformats.Sort Item Component: Changed
EventEmitter<any>toEventEmitter<void>since the emit() call doesn't pass any value.Flyout Instance: Made the constructor parameter
componentInstancerequired instead of optional, removing the deprecation warning.Repeater Service: Removed an outdated TODO comment (the type was already
SkyRepeaterExpandModeType, not includingstring).Updates since last revision
date.pipe.spec.tsanddate.service.spec.tsto match new format output:1/1/2000) to 2-digit years (1/1/00)2000-01-01 00 h 00to1/1/00, 12:00 hReview & Testing Checklist for Human
1/1/00instead of1/1/2000for all consumers usingshort,shortDate, etc.2000-01-01 00 h 00to1/1/00, 12:00 h(this is a significant change in locale-specific formatting)EventEmitter<void>change doesn't break consumers that might be subscribing and expecting a valueSkyFlyoutInstancewithout passingcomponentInstance- this will now be a compile errorRecommended Test Plan:
new SkyFlyoutInstanceto ensure all usages pass the required parameterNotes
Link to Devin run: https://app.devin.ai/sessions/e3d3658a90434b37865e9044c2af4e60
Requested by: @bcmake