Merge pull request #197 from bcnmy/feat/SMA-378-379-ABI-SVM-Audit-Rem…

…ediations SMA 379 ABI SVM audit remediations pt 1
bcnmy · Feb 14, 2024 · dddc887 · dddc887
2 parents 5df0325 + 6de8982
commit dddc887
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/contracts/smart-account/interfaces/modules/ISessionValidationModule.sol b/contracts/smart-account/interfaces/modules/ISessionValidationModule.sol
@@ -33,6 +33,8 @@ abstract contract ISessionValidationModule {
      * @param funcCallData the data for the call.
      * is parsed inside the Session Validation Module (SVM)
      * @param sessionKeyData SessionKey data, that describes sessionKey permissions
+     * @param callSpecificData additional data for the call, that is parsed inside the SVM
+     * @return the Session Key address (public key) that was used to sign the call
      */
     function validateSessionParams(
         address destinationContract,

diff --git a/contracts/smart-account/modules/SessionValidationModules/ABISessionValidationModule.sol b/contracts/smart-account/modules/SessionValidationModules/ABISessionValidationModule.sol
@@ -59,7 +59,7 @@ contract ABISessionValidationModule is ISessionValidationModule {
             "ABISV Not Execute Selector"
         );
 
-        address destContract;
+        uint160 destContract;
         uint256 callValue;
         bytes calldata data;
         assembly {
@@ -84,7 +84,7 @@ contract ABISessionValidationModule is ISessionValidationModule {
 
         return
             _validateSessionParams(
-                destContract,
+                address(destContract),
                 callValue,
                 data,
                 _sessionKeyData