Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi owned ecdsa remediations #189

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Jan 15, 2024

Summary

Issues remediations according to the audit

Related Issue: #347

Change Type

  • Refactor

Checklist

  • My code follows this project's style guidelines
  • I've reviewed my own code
  • I've added comments for any hard-to-understand areas
  • I've updated the documentation if necessary
  • My changes generate no new warnings
  • I've added tests that prove my fix is effective or my feature works
  • All unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Copy link

linear bot commented Jan 15, 2024

@filmakarov filmakarov changed the base branch from main to develop January 15, 2024 08:34
@livingrockrises
Copy link
Contributor

Approved

@filmakarov
Copy link
Collaborator Author

Waiting for Auditor's comments

@Aboudjem
Copy link
Contributor

LGTM just need this to be updated:

string public constant NAME = "ECDSA Ownership Registry Module";

@livingrockrises
Copy link
Contributor

LGTM just need this to be updated:

string public constant NAME = "ECDSA Ownership Registry Module";

Is this resolved? @filmakarov

@livingrockrises
Copy link
Contributor

Waiting for Auditor's comments

also resolve this if done. ready to merge from my side

@filmakarov
Copy link
Collaborator Author

Fixed the name.
Auditors approval pending

Copy link
Contributor

@Aboudjem Aboudjem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@livingrockrises livingrockrises merged commit 41403f8 into develop Jan 16, 2024
2 checks passed
@filmakarov filmakarov deleted the feat/SMA-347-MultiOwnedEcdsa-Remediations branch January 16, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants