Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-684] Update spot_ros2 metadata #270

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

tcappellari-bdai
Copy link
Collaborator

@tcappellari-bdai tcappellari-bdai commented Feb 16, 2024

Change Overview

I added package descriptions to the packages missing one and standardized all the maintainer and license info

Testing Done

N/A

Copy link
Collaborator Author

tcappellari-bdai commented Feb 16, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

coveralls-official bot commented Feb 16, 2024

Pull Request Test Coverage Report for Build 7980472670

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.434%

Totals Coverage Status
Change from base Build 7975294414: 0.0%
Covered Lines: 1840
Relevant Lines: 4397

💛 - Coveralls

Copy link
Collaborator

@khughes-bdai khughes-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed there are still some missing licenses in the packages in the examples directory, could those be added too?

Copy link
Collaborator

@khughes-bdai khughes-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tcappellari-bdai tcappellari-bdai merged commit e72f279 into main Feb 20, 2024
4 checks passed
@tcappellari-bdai tcappellari-bdai deleted the SW-684-update-spot-packages-metadata branch February 20, 2024 21:58
marlow-fawn pushed a commit to marlow-fawn/spot_ros2 that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants