Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-2051] expose foot contact states to state streaming handler #598

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

tcappellari-bdai
Copy link
Collaborator

Change Overview

expose foot contact states in state streaming handler

Testing Done

Please create a checklist of tests you plan to do and check off the ones that have been completed successfully. Ensure that ROS 2 tests use domain_coordinator to prevent port conflicts. Further guidance for testing can be found on the ros utilities wiki.

@coveralls
Copy link

coveralls commented Feb 27, 2025

Pull Request Test Coverage Report for Build 13635319815

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.487%

Totals Coverage Status
Change from base Build 13527600153: 0.0%
Covered Lines: 1952
Relevant Lines: 3719

💛 - Coveralls

Copy link
Collaborator

I think to get these exported as a state interface, you'll first have to modify the ros2 control tags in the urdf to add in sensor related interfaces. it's definitely a non standard sensor type so idk the best way to do it, but maybe something like this?

        <sensor name="feet_contacts">
            <state_interface name="foot_state.front.left"/>
            <state_interface name="foot_state.front.right"/>
            <state_interface name="foot_state.rear.left"/>
            <state_interface name="foot_state.rear.right"/>
        </sensor>

@tcappellari-bdai tcappellari-bdai force-pushed the SW-2051-expose-feet-contact-states branch from 88cf7aa to b77b3c5 Compare March 5, 2025 16:32
@tcappellari-bdai tcappellari-bdai force-pushed the SW-2051-expose-feet-contact-states branch from b77b3c5 to f3ca03b Compare March 6, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants