Test MNE can read our exports #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
- Coverage 95.59% 95.57% -0.02%
==========================================
Files 4 3 -1
Lines 295 294 -1
==========================================
- Hits 282 281 -1
Misses 13 13 ☔ View full report in Codecov by Sentry. |
ararslan
reviewed
Oct 8, 2024
| @testset "Exports readable by MNE" begin | ||
| edf = EDF.read(joinpath(DATADIR, "test_float_extrema.edf")) | ||
| @test edf.signals[1].header.digital_minimum ≈ -32767.0f0 | ||
| edf = @set edf.signals[1].header.digital_minimum = -32767 * 2 |
There was a problem hiding this comment.
I don't understand what the purpose of this is. If it's necessary for testing a particular behavior, can you add a comment? I think it's the only use of Accessors here so if it's not actually necessary then dropping it would reduce the number of test dependencies.
There was a problem hiding this comment.
this PR was meant to complement #72 which uses Accessors more extensively in the tests
however I no longer remember what the point of this line is anymore :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a bunch of test-only dependencies but no runtime deps. This also has no source code changes.