Fix compatibility with AWS.jl 1.91+ #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omus
commented
Feb 4, 2025
Project.toml
Outdated
| @@ -10,11 +10,11 @@ YAML = "ddb6d928-2868-570f-bddf-ab3f9cf99eb6" | |||
| goaws_jll = "a437b02d-256c-57cc-b5c6-817ed6633e35" | |||
|
|
|||
| [compat] | |||
| AWS = "1.8 - 1.90" | |||
| AWS = "1.91" | |||
There was a problem hiding this comment.
I'll look into supporting older versions of AWS.jl as this would allow for better compatiblity
There was a problem hiding this comment.
I think we intended on using 1.80 here as 1.8.0 doesn't support AbstractAWSConfig which this package requires. We at a minimum require 1.63 which added support for @service
There was a problem hiding this comment.
Restricting further to AWS.jl 1.78 as this version allows us to use Compat.jl 4 which is needed to run the tests. I'd rather not state this package supports AWS.jl 1.63 if we can't actually tests against it
omus
force-pushed
the
cv/aws.jl-1.91-compat
branch
from
e20cc33 to
41a9588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9 we found that AWS.jl 1.91 was not compatible with GoAWS.jl due to the underlying
goawslibrary not supporting JSON APIs. Since we mitigated that issue with a upperbound workaround thegoawspackage now has support for JSON APIs so we can address this issue properly.Related:
goawsPR to support JSON APIs: [WIP] Feature aws json Admiral-Piett/goaws#288