add ContextlessAnnotation #144
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-26
to
36
| #= 5 =# AnnotationV1(recording=recs[2], id=uuid4(), span=TimeSpan(67, 95)), | ||
| #= 6 =# AnnotationV1(recording=recs[2], id=uuid4(), span=TimeSpan(15, 170)), | ||
| #= 7 =# AnnotationV1(recording=recs[1], id=uuid4(), span=TimeSpan(43, 89)), | ||
| #= 8 =# AnnotationV1(recording=recs[3], id=uuid4(), span=TimeSpan(0, 50)), | ||
| #= 9 =# AnnotationV1(recording=recs[2], id=uuid4(), span=TimeSpan(2, 10)), | ||
| #= 10 =# AnnotationV1(recording=recs[1], id=uuid4(), span=TimeSpan(111, 140)), | ||
| #= 11 =# AnnotationV1(recording=recs[3], id=uuid4(), span=TimeSpan(60, 100)), | ||
| #= 12 =# AnnotationV1(recording=recs[3], id=uuid4(), span=TimeSpan(23, 80)), | ||
| #= 13 =# AnnotationV1(recording=recs[3], id=uuid4(), span=TimeSpan(100, 110)), | ||
| #= 14 =# AnnotationV1(recording=recs[1], id=uuid4(), span=TimeSpan(200, 300))] | ||
| sources = [AnnotationV1(recording=recs[1], id=uuid4(), span=TimeSpan(0, 100)), #= 1 =# | ||
| AnnotationV1(recording=recs[2], id=uuid4(), span=TimeSpan(55, 100)), #= 2 =# | ||
| AnnotationV1(recording=recs[1], id=uuid4(), span=TimeSpan(34, 76)), #= 3 =# | ||
| AnnotationV1(recording=recs[1], id=uuid4(), span=TimeSpan(120, 176)), #= 4 =# | ||
| AnnotationV1(recording=recs[2], id=uuid4(), span=TimeSpan(67, 95)), #= 5 =# | ||
| AnnotationV1(recording=recs[2], id=uuid4(), span=TimeSpan(15, 170)), #= 6 =# | ||
| AnnotationV1(recording=recs[1], id=uuid4(), span=TimeSpan(43, 89)), #= 7 =# | ||
| AnnotationV1(recording=recs[3], id=uuid4(), span=TimeSpan(0, 50)), #= 8 =# | ||
| AnnotationV1(recording=recs[2], id=uuid4(), span=TimeSpan(2, 10)), #= 9 =# | ||
| AnnotationV1(recording=recs[1], id=uuid4(), span=TimeSpan(111, 140)), #= 10 =# | ||
| AnnotationV1(recording=recs[3], id=uuid4(), span=TimeSpan(60, 100)), #= 11 =# | ||
| AnnotationV1(recording=recs[3], id=uuid4(), span=TimeSpan(23, 80)), #= 12 =# | ||
| AnnotationV1(recording=recs[3], id=uuid4(), span=TimeSpan(100, 110)), #= 13 =# | ||
| AnnotationV1(recording=recs[1], id=uuid4(), span=TimeSpan(200, 300))] #= 14 =# | ||
| merged = merge_overlapping_annotations(sources) |
There was a problem hiding this comment.
these changes seem unrelated?
There was a problem hiding this comment.
formatter autoformatted, my bad. Will fix
|
On slack we decided the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when one only has a Samples object (and not a signal), and they run some algorithm over it that generates annotations, that algo doesn’t have the context of recording or start of the signal, and can only output things relative to the samples itself. That leads to the need for something like this
ContextlessSpanV1.More beacon-internal context: https://beacon-biosignals.slack.com/archives/CKS1Y5F5X/p1695907224398859