fix for Arrow 2.7 #153
Merged
fix for Arrow 2.7 #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericphanson
reviewed
Jan 26, 2024
src/samples.jl
Outdated
Comment on lines
584
to
585
| # XXX in Arrow 2.7, the extra indirection with `fromarrowstruct` leads to the named tuple | ||
| # being splatted as positional arguments and not keyword args unless we add this method. |
There was a problem hiding this comment.
I might be missing something obvious here, but looking at https://github.com/apache/arrow-julia/pull/493/files, I don't see how it was ever splatting it as keyword arguments 🤔. Is that right, or was it something else?
ericphanson
approved these changes
Jan 26, 2024
Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
|
Thinking about this a bit more, I think alternatively, we could have bumped compat to Arrow 2.7 and used |
|
@ericphanson I had also thought about that. 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.