Initial Setup #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| # issue #26939 | ||
| d26939 = WeakKeyIdDict() | ||
| d26939[big"1.0" + 1.1] = 1 |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| d26939[big"1.0" + 1.1] = 1 | |
| d26939[big"1.0"+1.1] = 1 |
ericphanson
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
I did not check every line in detail, but as a copy-paste of reviewed code it looks good to me. I think we should also copy all the Base.Iddict tests before making a release, since we should have identical semantics in the case the keys are not GC'd (which we can ensure by keeping a global reference to the keys we test with for example). They deal with a lot of tricky edge cases there that I think would be great to ensure we have tested here. (Not blocking for this PR).
Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary copy/paste from https://github.com/Nemocas/AbstractAlgebra.jl/blob/f33f5de5e471938acbd06565245d839df4622916/src/WeakKeyIdDict.jl
and boilerplate setup