Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some tests from Base #4

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Add some tests from Base #4

merged 5 commits into from
Apr 4, 2024

Conversation

haberdashPI
Copy link
Member

github-actions[bot]
github-actions bot reviewed Apr 4, 2024
View reviewed changes
src/WeakKeyIdDicts.jl Outdated Show resolved Hide resolved
src/WeakKeyIdDicts.jl Outdated Show resolved Hide resolved
@haberdashPI haberdashPI requested a review from ericphanson April 4, 2024 15:16
ericphanson
ericphanson approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@ericphanson ericphanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests look good, and nice that it caught the missing convert. Are there other tests we should port over?

@haberdashPI haberdashPI requested a review from ericphanson April 4, 2024 16:09
@haberdashPI
Copy link
Member Author

tests look good, and nice that it caught the missing convert. Are there other tests we should port over?

I hunted around some more in that file and found some others that made sense to add.

@haberdashPI haberdashPI merged commit 601f126 into main Apr 4, 2024
7 checks passed
@haberdashPI haberdashPI deleted the dfl/base-tests branch April 4, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ericphanson ericphanson ericphanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve test coverage
2 participants
@haberdashPI @ericphanson