Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license #7

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Update license #7

merged 2 commits into from
Apr 11, 2024

Conversation

haberdashPI
Copy link
Member

correctly refer to abstractalgebra's license type

@haberdashPI haberdashPI self-assigned this Apr 11, 2024
@haberdashPI haberdashPI requested a review from ericphanson April 11, 2024 13:23
LICENSE.md Outdated

> Copyright (c) 2014-2016: William Hart, Tommy Hofmann, Claus Fieker, Fredrik Johansson.
> Copyright (c) 2014-2016: William Hart, Tommy Hofmann, Clause Fieker, Fredrik Johansson.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??? This was a copy paste of the quote text from that file. Maybe I'm missing something.

Since we are just using one of the .jl files I think this line from that file applies:

The individual .jl files in the AbstractAlgebra.jl package are licensed under the Simplified "2-clause" BSD License

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright (c) 2014-2016: William Hart, Tommy Hofmann, Claus Fieker, Fredrik Johansson.

Suggested change
> Copyright (c) 2014-2016: William Hart, Tommy Hofmann, Clause Fieker, Fredrik Johansson.
> Copyright (c) 2014-2016: William Hart, Tommy Hofmann, Claus Fieker, Fredrik Johansson.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow... curious how I did that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion, the vscode interface doesn't actually show the first suggestion

@haberdashPI haberdashPI requested a review from ericphanson April 11, 2024 13:32
@haberdashPI haberdashPI merged commit 41e82c5 into main Apr 11, 2024
@haberdashPI haberdashPI deleted the dfl/license-update branch April 11, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants