Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions documentation #8

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Fix permissions documentation #8

merged 3 commits into from
Nov 21, 2024

Conversation

omus
Copy link
Member

@omus omus commented Oct 9, 2024

The permission should be contents and not context (doesn't exist).

@omus omus requested a review from MKVatinyan October 9, 2024 14:07
@ineedjet
Copy link

Looks like

permissions:
  contents: read
  actions: read

Copy link
Contributor

@MKVatinyan MKVatinyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l21 needs same change
l49 "follow" -> "following"

@omus omus force-pushed the cv/permission-docs branch from 86e4ed0 to 27254df Compare November 21, 2024 17:44
@omus
Copy link
Member Author

omus commented Nov 21, 2024

l21 needs same change l49 "follow" -> "following"

Done

Looks like

permissions:
  contents: read
  actions: read

You are correct. This happens to work as the GitHub API we're using doesn't require this permission for public repositories: https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28#get-a-workflow-run-attempt

@omus omus requested a review from MKVatinyan November 21, 2024 17:50
@omus omus merged commit 656c4f5 into main Nov 21, 2024
14 checks passed
@omus omus deleted the cv/permission-docs branch November 21, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants