Skip to content

Add workaround for Julia 1.12.1#8

Merged
omus merged 8 commits intomainfrom
cv/julia-1.12
Nov 7, 2025
Merged

Add workaround for Julia 1.12.1#8
omus merged 8 commits intomainfrom
cv/julia-1.12

Conversation

@omus
Copy link
Copy Markdown
Member

@omus omus commented Nov 6, 2025

Adding CI tests against the latest releases of Julia to ensure we've retained compatibility with Julia 1.12.0 and 1.12.1.


@omus
Copy link
Copy Markdown
Member Author

omus commented Nov 6, 2025

Seeing failures like this on Julia 1.12.1:

ERROR: LoadError: Unknown package: Preferences

@omus
Copy link
Copy Markdown
Member Author

omus commented Nov 6, 2025

Looks like this was a side effect of JuliaLang/julia#59212

@omus
Copy link
Copy Markdown
Member Author

omus commented Nov 7, 2025

I've made an issue in the Julia repo about this: JuliaLang/julia#60077

@omus omus marked this pull request as ready for review November 7, 2025 14:32
@omus omus requested a review from kleinschmidt November 7, 2025 14:32
@omus omus changed the title Test against Julia 1.12 Add workaround for Julia 1.12.1 Nov 7, 2025
Copy link
Copy Markdown
Member

@iamed2 iamed2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we gain anything by attempting to precompile indirect dependencies on other Julia versions? Won't those get precompiled automatically anyway when the direct dependencies are precompiled?

@omus
Copy link
Copy Markdown
Member Author

omus commented Nov 7, 2025

Do we gain anything by attempting to precompile indirect dependencies on other Julia versions? Won't those get precompiled automatically anyway when the direct dependencies are precompiled?

I thought about this and I think the original intent was to just be explicit about the packages we care about precompiling. Just passing in the direct dependencies should be good enough. If there is a corner case where being explicit about all dependencies is required then our tests currently don't catch that. As this is intended to just be a bugfix limiting the change to just 1.12.1+ should allow us to catch scenarios we haven't considered without breaking older Julia versions.

@omus omus merged commit 40490cc into main Nov 7, 2025
7 checks passed
@omus omus deleted the cv/julia-1.12 branch November 7, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants