chore: update ESLint configuration and improve image handling#195
chore: update ESLint configuration and improve image handling#195tnkshuuhei wants to merge 1 commit intofeat/semantic-scholarfrom
Conversation
tnkshuuhei
commented
Feb 26, 2026
- Added @typescript-eslint/eslint-plugin to ESLint configuration for better TypeScript support.
- Disabled the default no-unused-vars rule and replaced it with @typescript-eslint/no-unused-vars for improved linting of unused variables.
- Updated ImagePreview component to use Next.js Image component for optimized image loading.
- Minor refactor in step-process-dialog to simplify step mapping.
- Added eslint-disable comment for native
usage in OG image generation.
- Added @typescript-eslint/eslint-plugin to ESLint configuration for better TypeScript support. - Disabled the default no-unused-vars rule and replaced it with @typescript-eslint/no-unused-vars for improved linting of unused variables. - Updated ImagePreview component to use Next.js Image component for optimized image loading. - Minor refactor in step-process-dialog to simplify step mapping. - Added eslint-disable comment for native <img> usage in OG image generation.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review: chore: update ESLint configuration and improve image handlingOverall this is a clean, well-scoped PR. The intent behind each change is clear. A few things worth addressing before merging: Bug / Missing Dependency
Run ESLint Config ChangesThe One small note: the plugin is configured without Consider promoting ImagePreview —
|
| Area | Status |
|---|---|
Missing @typescript-eslint/eslint-plugin dep |
Needs fix |
ESLint rule migration (no-unused-vars) |
Correct |
next/image with unoptimized for data URLs |
Works, minor concern on hardcoded dimensions |
OG image eslint-disable comment |
Correct |
Unused index removal |
Good cleanup |
The only blocking issue is the missing explicit package dependency. Everything else is good to go after that is addressed.