ci(github): Include Node 20 for older glibc

Fixes: #244 Signed-off-by: Martin Styk <mart.styk@gmail.com>
beaker-project · Feb 3, 2025 · 2f0165a · 2f0165a
1 parent f2fe551
commit 2f0165a
Showing 1 changed file with 25 additions and 16 deletions.
diff --git a/.github/workflows/review-checks.yml b/.github/workflows/review-checks.yml
@@ -14,16 +14,17 @@ on:
 
 jobs:
   validate-docs:
-    env:
-      # https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
-      ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION: node16
-      ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
     runs-on: ubuntu-latest
     container:
       image: centos:7
-
+      volumes:
+        - /node20217:/node20217:rw,rshared
+        - /node20217:/__e/node20:ro,rshared
     steps:
-    - uses: actions/checkout@v1
+    - name: Fetch Node 20
+      run: |
+        curl -LO https://unofficial-builds.nodejs.org/download/release/v20.9.0/node-v20.9.0-linux-x64-glibc-217.tar.xz
+        tar -xf node-v20.9.0-linux-x64-glibc-217.tar.xz --strip-components 1 -C /node20217
     - name: Fixup CentOS repo files
       run: |
         sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/*.repo
@@ -36,14 +37,15 @@ jobs:
     - name: Fetch Beaker repository
       run: |
         wget https://beaker-project.org/yum/beaker-server-RedHatEnterpriseLinux.repo -P /etc/yum.repos.d/
+    - uses: actions/checkout@v4
     - name: Install Beaker dependency from specfile
       run: |
         yum-builddep *.spec -y
     - name: Build documentation
       run: |
         make -C documentation html SPHINXOPTS="-W"
         mv documentation/_build/html /__w
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: beaker-docs
         path: /home/runner/work/html
@@ -54,16 +56,16 @@ jobs:
       MYSQL_USER: beaker
       MYSQL_PASSWORD: beaker
       MYSQL_ROOT_PASSWORD: toor
-      # https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
-      ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION: node16
-      ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
     strategy:
       fail-fast: false
       matrix:
         test-target: ["bkr.inttest.client", "bkr.inttest.labcontroller", "bkr.inttest.server"]
     container:
       image: centos:7
       options: --init
+      volumes:
+        - /node20217:/node20217:rw,rshared
+        - /node20217:/__e/node20:ro,rshared
     services:
       database:
         image: mariadb:10-ubi
@@ -74,6 +76,10 @@ jobs:
         ports:
           - 3306
     steps:
+      - name: Fetch Node 20
+        run: |
+          curl -LO https://unofficial-builds.nodejs.org/download/release/v20.9.0/node-v20.9.0-linux-x64-glibc-217.tar.xz
+          tar -xf node-v20.9.0-linux-x64-glibc-217.tar.xz --strip-components 1 -C /node20217
       - name: Fixup CentOS repo files
         run: |
           sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/*.repo
@@ -143,13 +149,12 @@ jobs:
 
   unit-tests:
     runs-on: ubuntu-latest
-    env:
-      # https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
-      ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION: node16
-      ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
     container:
       image: ${{ matrix.os-target.name }}
       options: --init
+      volumes:
+        - /node20217:/node20217:rw,rshared
+        - /node20217:/__e/node20:ro,rshared
     strategy:
       fail-fast: false
       matrix:
@@ -170,7 +175,11 @@ jobs:
           sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/*.repo
           sed -i s/^#.*baseurl=http/baseurl=http/g /etc/yum.repos.d/*.repo
           sed -i s/^mirrorlist=http/#mirrorlist=http/g /etc/yum.repos.d/*.repo
-
+      - name: Fetch Node 20
+        run: |
+          yum install xz -y
+          curl -LO https://unofficial-builds.nodejs.org/download/release/v20.9.0/node-v20.9.0-linux-x64-glibc-217.tar.xz
+          tar -xf node-v20.9.0-linux-x64-glibc-217.tar.xz --strip-components 1 -C /node20217
       - name: Set BKR_PY3 environment variable
         run: echo "BKR_PY3=1" >> $GITHUB_ENV
         if: matrix.os-target.name != 'centos:7'
@@ -206,4 +215,4 @@ jobs:
       - name: Run unit tests
         run: |
           pushd ${{ matrix.test-target }}
-          ./run-tests.sh
+          ./run-tests.sh