Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement of old, deprecated aliases for unit-test methods #252

Merged

Conversation

ssaakian
Copy link
Contributor

No description provided.

ssaakian and others added 2 commits February 17, 2025 19:55
When attempting to build beaker client for fedora39, saw
the error `ModuleNotFoundError: No module named 'six' `
during build of `documentation/config.py`. This changeset
resolves that problem. reference EXDRHUB-2907 for further
details.
Those were removed in Python 3.12.

See https://docs.python.org/3.12/whatsnew/3.12.html#removed

Note that this was a search and replace job,
some of the asserts might be easier to read if spelled out differently,
e.g. using assertIn(..., ...) instead of assertTrue(... in ...),
but this is out of scope of this commit.
@StykMartin StykMartin changed the title ITBEAKER-215 push batch 3&4 Replacement of old, deprecated aliases for unit-test methods Feb 18, 2025
@StykMartin
Copy link
Contributor

There is one more problem is test_proxy.py

Traceback (most recent call last):
  File "/__w/beaker/beaker/IntegrationTests/src/bkr/inttest/labcontroller/test_proxy.py", line 1010, in test_xmlrpc_task_log_after_finished
    except xmlrpclib.Fault as fault:
NameError: global name 'xmlrpclib' is not defined

This doesn't honor six import

@StykMartin StykMartin merged commit b598aed into beaker-project:python-3 Feb 20, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants