fix: [#334] Fix incorrect ordering of serialized lists #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to me. Thanks for the new test that'll catch this regression going forward. |
protestContest
force-pushed
the
serializer-fix
branch
from
c945aff to
ab4cc45
Compare
protestContest
force-pushed
the
serializer-fix
branch
from
ab4cc45 to
869eb0c
Compare
protestContest
changed the title
|
@mattpolzin I pushed some updates to satisfy the CI checks, but it looks like something weird happened with the deps in a couple of them. Can you re-run the checks? |
|
Looks all good now. Can you bump the patch version number in this PR to save a bit of time (it'll release right away when we merge this PR that way). |
|
On second thought, I see some of the changes made to the common configs in this project may do releases differently now. I'll merge this as-is and see if the automation just takes over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change introduced in
JSONAPI.Serializerhere (and a couple nearby spots) incorrectly orders a list response.This fixes the list reversal, or reverts it in some places. List concatenation should be efficient enough in this instance.
Closes #334