Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DIDCommV1 legacy service #7

Closed
wants to merge 2 commits into from
Closed

Conversation

conanoc
Copy link

@conanoc conanoc commented Apr 16, 2024

PeerDIDHelper already had PeerDIDServiceLegacy which was the service type of DIDCommV1, but recipientKeys property was missing.

This change allows PeerDIDHelper to create a numAlgo 2 peer-did with the legacy service. This has been tested with the Credo-ts to do did-exchange protocol which exchanges numAlgo 2 peer-dids.

@beatt83
Copy link
Owner

beatt83 commented Apr 16, 2024

Hi @conanoc. First thanks for contributing it means a lot. :)

I understand the changes you're making and your right. But I don't think this changes should come in here besides the routingKeys.

I need to change DID Core library so the Service is a AnyCodable and then you can insert extensions to the json, so this specific case you have will work then.

Let me see what I can do around this today and tomorrow and come back to you.

@beatt83
Copy link
Owner

beatt83 commented Apr 16, 2024

@conanoc can you check this? #8

With this you can add any extension to the service or serviceEndpoint, I see DIDCommV1 uses as well priority with this changes that is possible.

@conanoc
Copy link
Author

conanoc commented Apr 16, 2024

#8 Looks perfect. Thanks!

@conanoc conanoc closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants