-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOJ - Made modules local #4
Conversation
@@ -29,7 +29,6 @@ func logCommandAndArgs() { | |||
|
|||
func main() { | |||
logCommandAndArgs() | |||
systemd.FindClamdProcess() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not seem useful ?
iface.MacAddress = mac | ||
ifaces := []types.NetworkEntry{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably was supposed to be ctypes (and no double imports)
) | ||
|
||
type MainInterface struct { | ||
Dst string `json:"dst"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intellij did all that reformatting - not sure why most other files were seemingly formatted properly but this one ?
} | ||
isRunning := slices.ContainsFunc(lines, func(process string) bool { | ||
return strings.Contains(process, "clamd") | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arguably, we woudn't really need to loop thru lines, we could just look for the small string in the big string :-)
Why
Mostly because they can be and probably should be :-)
I am also cunningly hoping this will be worthy of the next tagged release and therefore trigger the creation of ArchLinux packages, mouaaaah...