NOJ - Made modules local #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr211
commented
Jun 21, 2024
| @@ -29,7 +29,6 @@ func logCommandAndArgs() { | |||
|
|
|||
| func main() { | |||
| logCommandAndArgs() | |||
| systemd.FindClamdProcess() | |||
There was a problem hiding this comment.
does not seem useful ?
gr211
commented
Jun 21, 2024
| iface.MacAddress = mac | ||
| ifaces := []types.NetworkEntry{} |
There was a problem hiding this comment.
probably was supposed to be ctypes (and no double imports)
gr211
commented
Jun 21, 2024
| ) | ||
|
|
||
| type MainInterface struct { | ||
| Dst string `json:"dst"` |
There was a problem hiding this comment.
Intellij did all that reformatting - not sure why most other files were seemingly formatted properly but this one ?
gr211
commented
Jun 21, 2024
| } | ||
| isRunning := slices.ContainsFunc(lines, func(process string) bool { | ||
| return strings.Contains(process, "clamd") | ||
| }) |
There was a problem hiding this comment.
arguably, we woudn't really need to loop thru lines, we could just look for the small string in the big string :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Mostly because they can be and probably should be :-)
I am also cunningly hoping this will be worthy of the next tagged release and therefore trigger the creation of ArchLinux packages, mouaaaah...