-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ASCII85 decoding #244
base: main
Are you sure you want to change the base?
Add ASCII85 decoding #244
Conversation
CheckerTypes::CheckAthena(athena_checker) | ||
} | ||
|
||
#[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add more tests for base85 vs ascii85. There should be tests to make sure this only decodes ascii85 and not base85. Also add tests with longer strings and special characters in the plaintext. See the base64 URL tests for an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give me a base85 string that isn't ascii85? All the online decoders seems to use the same encoding mechanism for both.
cargo fmt fails :( |
Ahhhh looks like it's just clippy left!! :)
|
So now all the test pass, except the test suite which gets cancelled for taking too long. |
Related to #61
Feedback is welcome!