Migrate from isort/Black/Flake8 to Ruff for Code Formatting and Linting #5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snejus
force-pushed
the
configure-ruff
branch
10 times, most recently
from
292996f
to
52507cf
Compare
Adjust the base URL to perform a '/search' instead of attempting to '/get' specific lyrics where we're unlikely to find lyrics for the specific combination of album, artist, track names and the duration (see https://lrclib.net/docs). Since we receive an array of matching lyrics candidates, rank them by their duration similarity to the item's duration, and whether they contain synced lyrics.
Create 'helpers.ConfigMixin' which sets up testing configuration. This is helpful for tests (e.g. test_lyrics.py) that only need the configuration and do not require temp dir. (#5102) Refactor lyrics tests to fix the issue global beets config issue. Additionally, add 'integration_test' mark that can be used to mark tests that should only run once a week.
Improve requests performance with requests.Session which uses connection pooling for repeated requests to the same host. Additionally, this centralizes request configuration, making sure that we use the same timeout and provide beets user agent for all requests.
Due to request error handling this logic will only run for successful requests, so we can safely assume the html to be a string.
Tidy up 'Google.is_page_candidate' method and remove 'Google.sluggify' method which was a duplicate of 'slug'. Since 'GeniusFetchTest' only tested whether the artist name is cleaned up (the rest of the functionality is patched), remove it and move its test cases to the 'test_slug' test.
snejus
force-pushed
the
fix-lrclib-lyrics
branch
from
622ed3c
to
3eb04ba
Compare
- Fix imports - Fix pytest issues - Do not assign lambda as variable - Use isinstance instead of type to check type - Rename ambiguously named variables - Name custom errors with Error suffix
snejus
force-pushed
the
configure-ruff
branch
from
52507cf
to
3cbecf2
Compare
* Replace `noqa` comments in `assert...` method definitions with a configuration option to ignore these names. * Use the `__all__` variable to specify importable items from the module, replacing `*` imports and `noqa` comments for unused imports. * Address issues with poorly named variables and methods by renaming them appropriately.
The variable in `test_ordered_enum` was flagged for naming issues, and I noticed that `OrderedEnum` is essentially `enum.IntEnum`. I guess `OrderedEnum` exists because it was created before `enum.IntEnum` was made available in Python 3.4. We do not need it anymore though, so it's now gone.
snejus
force-pushed
the
configure-ruff
branch
from
3cbecf2
to
ef83264
Compare
This commit introduces a `.git-blame-ignore-revs` file to the repository. The purpose of this file is to list specific commit hashes that should be ignored when using the `git blame` command. This is useful for ignoring commits that involve large-scale formatting changes, refactoring, or other non-functional changes that would otherwise clutter the blame history. I added a couple of previous commit hashes which reformatted the code. Configure this repository to use this file: git config --local blame.ignoreRevsFile .git-blame-ignore-revs
snejus
force-pushed
the
configure-ruff
branch
from
ef83264
to
9b6b1e9
Compare
bal-e
approved these changes
Sep 19, 2024
|
|
||
| .. code-block:: python | ||
| In order to add such test, mark your test with the ``integration_test`` marker |
There was a problem hiding this comment.
typo: replace with "In order to add such a test"
| "Invalid `release_date` returned " | ||
| "by {} API: '{}'".format(self.data_source, release_date) | ||
| f"Invalid `release_date` returned by {self.data_source} API: " | ||
| f"{release_date!r}" |
There was a problem hiding this comment.
The !r component is new, is it intentional?
snejus
force-pushed
the
fix-lrclib-lyrics
branch
from
3eb04ba
to
4d481d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I noticed one of recently merged PRs used
unittestassertions that we are migrating from. Thus, I thought it would be a good idea to configure our linting to catch such issues in the future. Since I was here, I replaced our multiple linting and formatting tools with a single tool, Ruff, to simplify and speed up our development workflow.Summary
This PR migrates the codebase from using isort, Black and Flake8 to Ruff for code formatting and linting. The changes include updates to the GitHub Actions workflow, pre-commit configuration, and documentation to reflect the new tooling.
Changes
GitHub Actions Workflow
.github/workflows/lint.ymlto usepoetry install --only=lintandpoe lint --output-format=github.Pre-commit Configuration
.pre-commit-config.yaml.Documentation
CONTRIBUTING.rstto reflect the use of Ruff for formatting and linting.Poetry Configuration
poetry.lockandpyproject.toml.pyproject.toml.Setup Configuration
setup.cfg.Git blame
.git-blame-ignore-revsfile to keep git blame clean from formattingchanges. Configure your local
beetsrepository to use this file by running:$ git config --local blame.ignoreRevsFile .git-blame-ignore-revsBenefits
How to Test
Linting and Formatting
poe check-formatto check for formatting issues.poe formatto format the codebase.poe lintto check for linting issues.Pre-commit Hooks
pre-commit run --all-files.CI Pipeline
Notes
unittesttopytestare welcome.requests_mockand tested weekly in the integration test suite.References
This PR aims to streamline our development process by adopting Ruff, a modern and efficient tool for Python code formatting and linting.