Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/setup-python from 5.1.1 to 5.2.0 #164

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 1, 2024

Bumps actions/setup-python from 5.1.1 to 5.2.0.

Release notes

Sourced from actions/setup-python's releases.

v5.2.0

What's Changed

Bug fixes:

  • Add .zip extension to Windows package downloads for Expand-Archive Compatibility by @​priyagupta108 in actions/setup-python#916 This addresses compatibility issues on Windows self-hosted runners by ensuring that the filenames for Python and PyPy package downloads explicitly include the .zip extension, allowing the Expand-Archive command to function correctly.
  • Add arch to cache key by @​Zxilly in actions/setup-python#896 This addresses issues with caching by adding the architecture (arch) to the cache key, ensuring that cache keys are accurate to prevent conflicts

Documentation changes:

Dependency updates:

New Contributors

Full Changelog: actions/setup-python@v5...v5.2.0

Commits
  • f677139 Bump pyinstaller from 3.6 to 5.13.1 in /tests/data (#923)
  • 2bd53f9 Documentation update for caching poetry dependencies (#908)
  • 80b49d3 fix: add arch to cache key (#896)
  • 036a523 Fix: Add .zip extension to Windows package downloads for Expand-Archive C...
  • 04c1311 Fix display of emojis in contributors doc (#899)
  • cb68456 Updated @​iarna/toml version to 3.0.0 (#912)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.1.1 to 5.2.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v5.1.1...v5.2.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 1, 2024
@rmartin16
Copy link
Member

FWIW, I've been seeing the AppImage failure elsewhere; something broke with AppImage running with xvfb...

@freakboy3742
Copy link
Member

Is this the point at which we finalize the "We don't verify AppImage" transition? I've got exactly zero appetite to chase my tail on AppImage bugs.

@rmartin16
Copy link
Member

rmartin16 commented Sep 1, 2024

Ohhh....this is not a problem with AppImage and xvfb. This is happening because x-briefcase-automation is no longer compatible with Toga v0.3.1....which AppImage builds are still forced to use.

When we updated Automation to use on_running() instead of add_background_task(), it broke the ability for the test app to automatically exit in CI with older versions of Toga....so, it runs until the job times out.

I was hoping that manylinux_2_34 would have existed already...but we're still waiting. So, without a way to use a more recent Toga with AppImage in CI, I think we're forced to remove it. (And I guess CI for briefcase-linux-appimage-template is completely broken....unless we pin briefcase==0.3.19 or something...)

@freakboy3742
Copy link
Member

Ohhh....this is not a problem with AppImage and xvfb. This is happening because x-briefcase-automation is no longer compatible with Toga v0.3.1....which AppImage builds are still forced to use.

When we updated Automation to use on_running() instead of add_background_task(), it broke the ability for the test app to automatically exit in CI with older versions of Toga....so, it runs until the job times out.

Ah - that'll do it. I guess we could use asyncio.create_task() rather than on_running...? Or, at least, put that call behind a gate on the installed Toga version?

I was hoping that manylinux_2_34 would have existed already...but we're still waiting.

Yeah - not sure what the story is around manylinux base images - pypa/manylinux#1575 exists... but doesn't appear to have garnered any particular attention.

So, without a way to use a more recent Toga with AppImage in CI, I think we're forced to remove it. (And I guess CI for briefcase-linux-appimage-template is completely broken....unless we pin briefcase==0.3.19 or something...)

Or... give up on AppImage :-)

@rmartin16
Copy link
Member

Yeah - not sure what the story is around manylinux base images - pypa/manylinux#1575 exists... but doesn't appear to have garnered any particular attention.

It's being tracked here:

Right now, there's some debate about the remaining blockers I think...but it's close™️

@freakboy3742
Copy link
Member

Ok - so the question for us is what to do in the interim. Do we modify Briefcase to use the older Toga API, or do we just disable CI testing for AppImage?

My vote is for disabling AppImage testing for now; once manylinux_2_34 is available, we can re-enable it with an updated Toga version if we feel so inclined.

@rmartin16
Copy link
Member

I'm fine with disabling AppImage testing for beeware/.github's CI. Although, AppImage testing is only still enabled here and in briefcase-linux-appimage-template; we already disabled it everywhere else.

@freakboy3742 freakboy3742 merged commit 0333739 into main Sep 2, 2024
71 checks passed
@dependabot dependabot bot deleted the dependabot/github_actions/actions/setup-python-5.2.0 branch September 2, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants