Upgrade upload-artifact and download-artifact actions to v4
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmartin16
added a commit
to rmartin16/briefcase
that referenced
this pull request
Jan 3, 2024
rmartin16
added a commit
to rmartin16/briefcase
that referenced
this pull request
Jan 3, 2024
rmartin16
added a commit
to rmartin16/briefcase
that referenced
this pull request
Jan 3, 2024
rmartin16
added a commit
to rmartin16/toga
that referenced
this pull request
Jan 3, 2024
rmartin16
added a commit
to rmartin16/rubicon-objc
that referenced
this pull request
Jan 3, 2024
rmartin16
added a commit
to rmartin16/travertino
that referenced
this pull request
Jan 3, 2024
rmartin16
added a commit
to rmartin16/toga-chart
that referenced
this pull request
Jan 3, 2024
rmartin16
added a commit
to rmartin16/toga-chart
that referenced
this pull request
Jan 3, 2024
This was referenced Jan 3, 2024
freakboy3742
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
This all appears to match the approach that I was expecting, following the discussion on the upstream ticket.
I don't have a good read on whether the timeouts will end up being an issue for us - but worst case, we just need to re-run some workflows (or roll this back if it gets pathological).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
actions/upload-artifact@4.0.0andactions/download-artifact@4.0.0#77upload-artifactanddownload-artifactactions can be upgraded without other changes since they're already only dealing with unique artifactspython-package-createworkflow which is used by other repos to create an artifact containing the Python package created for repo.upload-artifactanddownload-artifact, artifacts created with v3 cannot be downloaded with v4....and vice versa.upload-artifactanddownload-artifactactions to v4 briefcase#1589upload-artifactanddownload-artifactactions to v4 toga#2318upload-artifactanddownload-artifactactions to v4 rubicon-objc#397upload-artifactanddownload-artifactactions to v4 travertino#124upload-artifactanddownload-artifactactions to v4 toga-chart#78PR Checklist: