Skip to content

Commit

Permalink
Upgrade RCEdit from v1.1.1 to v2.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
rmartin16 committed Nov 16, 2023
1 parent 4db325a commit 65e239c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions changes/xxx.feature.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
RCEdit v2.0.0 is now used to build Windows apps. Run ``briefcase upgrade`` to use this latest version.
2 changes: 1 addition & 1 deletion src/briefcase/integrations/rcedit.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class RCEdit(ManagedTool):
@property
def download_url(self) -> str:
return (
"https://github.com/electron/rcedit/releases/download/v1.1.1/rcedit-x64.exe"
"https://github.com/electron/rcedit/releases/download/v2.0.0/rcedit-x64.exe"
)

@property
Expand Down
4 changes: 2 additions & 2 deletions tests/integrations/rcedit/test_RCEdit__upgrade.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def side_effect_create_mock_appimage(*args, **kwargs):
# A download is invoked
mock_tools.download.file.assert_called_with(
url="https://github.com/electron/rcedit/"
"releases/download/v1.1.1/rcedit-x64.exe",
"releases/download/v2.0.0/rcedit-x64.exe",
download_path=tmp_path / "tools",
role="RCEdit",
)
Expand Down Expand Up @@ -60,7 +60,7 @@ def test_upgrade_rcedit_download_failure(mock_tools, rcedit, tmp_path):
# A download was invoked
mock_tools.download.file.assert_called_with(
url="https://github.com/electron/rcedit/"
"releases/download/v1.1.1/rcedit-x64.exe",
"releases/download/v2.0.0/rcedit-x64.exe",
download_path=tmp_path / "tools",
role="RCEdit",
)
4 changes: 2 additions & 2 deletions tests/integrations/rcedit/test_RCEdit__verify.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def side_effect_create_mock_appimage(*args, **kwargs):
# A download is invoked
mock_tools.download.file.assert_called_with(
url="https://github.com/electron/rcedit/"
"releases/download/v1.1.1/rcedit-x64.exe",
"releases/download/v2.0.0/rcedit-x64.exe",
download_path=tmp_path / "tools",
role="RCEdit",
)
Expand All @@ -95,7 +95,7 @@ def test_verify_rcedit_download_failure(mock_tools, tmp_path):
# A download was invoked
mock_tools.download.file.assert_called_with(
url="https://github.com/electron/rcedit/"
"releases/download/v1.1.1/rcedit-x64.exe",
"releases/download/v2.0.0/rcedit-x64.exe",
download_path=tmp_path / "tools",
role="RCEdit",
)

0 comments on commit 65e239c

Please sign in to comment.