Restore debug logging for -v flag
#1502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmartin16
force-pushed
the
restore-console-debug-logging
branch
from
f93bd81 to
8633b77
Compare
rmartin16
force-pushed
the
restore-console-debug-logging
branch
from
8633b77 to
3332ce8
Compare
freakboy3742
requested changes
Oct 21, 2023
There was a problem hiding this comment.
Given we've just done a release, my inclination is to hold off until we've got a true fix for the debug issue, rather than rush a hotfix into main. There's definitely some discussion to be had around the "full" fix, but I don't think the current main is sufficiently encumbered or the full fix that far off that a reversal is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
-vflag no longer prints debug output to the console #1501PR Checklist: