Copy permissions when merging macOS app packages #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsmith
reviewed
Oct 25, 2023
Comment on lines
248
to
250
| self.tools.shutil.copyfile(source_path, target_path) | ||
| # Ensure permissions as well. | ||
| self.tools.shutil.copymode(source_path, target_path) |
There was a problem hiding this comment.
shutil.copy looks like a simpler way of doing this.
There was a problem hiding this comment.
Gotta love an API that has 3 different ways to copy a file... excluding the handful of other options in other modules... 🙄
mhsmith
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1510
When merging app packages, file permissions (and in particular, the executable bit) are now preserved.
PR Checklist: