Building on Python 3.12 requires setuptools >=67
#1527
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is as much an FYI as anything, I suppose.
I was messing around with package building and noticed
setuptools_scm >=8
recommends (err...requires...)setuptools >=64
. Out of curiosity, I tried to build Briefcase withsetuptools ==60
using Python 3.12 but it bombs out insetuptools
on some import of nonexistent code. I bumpedsetuptools
until the build would work and landed at>=67
.For any of our purposes, this doesn't really matter since the latest version of
setuptools
will always be used. However, if someone tried to package Briefcase themselves, the currentsetuptools
version constraint isn't really truthful.Furthermore, if you were following greg's recent chain about moving to
pyproject.toml
, he pointed out that pinning build requirements can create downstream problems. So, while Briefcase is unlikely to be a dependency for anything....it doesn't generally seem reliable to use pinning here 😕At any rate...this'll make the
setuptools
build version constraint a little more truthful.PR Checklist: