Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about purging static content from iOS/macOS apps. #2162

Merged
merged 9 commits into from
Feb 19, 2025

Conversation

freakboy3742
Copy link
Member

Adds platform notes on how to purge binary content from apps on Apple platforms, to avoid issues with iOS App Store validation and issues with binary merging on macOS.

Fixes #2161

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 requested a review from mhsmith February 17, 2025 00:10
@mhsmith
Copy link
Member

mhsmith commented Feb 17, 2025

Can we take this opportunity to eliminate all the duplication between the app and xcode pages? They're already virtually identical. And including the same content on both pages will cause the user to waste time visually comparing them for differences.

We could move the common content to the top-level macOS page, and link to it from the sub-pages. This would also make the actual differences much more obvious.

@freakboy3742
Copy link
Member Author

I guess you're right - and the same is true for the Windows app and VS pages. There's already some inclusion blocks, but I suppose almost entire page except for the format description is a candidate for being an inclusion... which means we should probably just cut out the middle-man.

@freakboy3742 freakboy3742 requested a review from mhsmith February 19, 2025 02:19
@mhsmith mhsmith merged commit 16c9f13 into beeware:main Feb 19, 2025
57 checks passed
@freakboy3742 freakboy3742 deleted the apple-static-lib branch February 19, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't publish to appstore or testflight due to numpy, how to solve
2 participants