Remove workaround for python/cpython#81061. #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgelessus
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Looks good to me, aside from the changelog entry. Thank you!
(I didn't bother removing this earlier, because the remainder of ctypes_patch is still necessary. But it does make sense to remove this inner workaround once rubicon-objc drops support for the affected Python versions.)
Co-authored-by: dgelessus <dgelessus@users.noreply.github.com>
dgelessus
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubicon contains a ctypes_patch to work around python/cpython#49960, a limitation in returning structures or unions from a C function.
That workaround itself contains a workaround for python/cpython#81061. However, that issue was resolved by python/cpython#13364, which is available in Python 3.10+.
This PR modifies the use of the inner workaround so that it is only employed on older versions of Python. There are existing test cases to validate that the handling for the python/cpython#81061 case works.
The patch is structured so that when pyupgrade runs in ~October 2025 to remove Python 3.9 support, the removal of the conditional branches will leave working code.
PR Checklist: