Synchronize view change and retransmit task #761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Will |
|
Which scenario are you looking at? Receiving+adding a message in |
|
Fixed this by changing MessageCache |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/JGRP-2749
Note, I am not a fan of this way to fix, but there really needs to be some exclusion between these operations to not have dangling data around. To be honest looking at this class there are a lot of places that are referencing mutable collections that appear to be reachable from multiple threads, so I fear this won't fix other possible causes of CME that could happen.
For example another possible CME is if there is an UP event that removes an entry from the recv_table but we are sending a xmit task that is currently iterating upon it.
@belaban let me know how you want to proceed